fix(firefox): wire screen context option through to Juggler#39843
Closed
nadja-y wants to merge 1 commit intomicrosoft:mainfrom
Closed
fix(firefox): wire screen context option through to Juggler#39843nadja-y wants to merge 1 commit intomicrosoft:mainfrom
nadja-y wants to merge 1 commit intomicrosoft:mainfrom
Conversation
nadja-y
force-pushed
the
pr-firefox-screen-override
branch
from
7cb2879 to
3367932
Compare
Member
|
cc @aslushnikov |
Wires the screen context option through Juggler to Firefox's native SetScreenAreaOverride API (https://phabricator.services.mozilla.com/D273425, mozilla-firefox/firefox@a689946) to decouple screen dimensions from Responsive Design Mode emulation. When screen differs from viewport, Juggler now uses setScreenAreaOverride instead of inRDMPane — achieving parity with how Chromium handles this via setDeviceMetricsOverride and WebKit via setScreenSizeOverride. The Firefox revision now pinned in UPSTREAM_CONFIG.sh (mozilla-firefox/firefox@4eb5a4f) includes this API natively, so bootstrap.diff changes are no longer required (cf. microsoft@3367932). Fixes microsoft#39841
nadja-y
force-pushed
the
pr-firefox-screen-override
branch
from
3367932 to
0a874f9
Compare
Contributor
Author
|
Rebased onto main. The Firefox revision now pinned in UPSTREAM_CONFIG.sh includes SetScreenAreaOverride natively, so bootstrap.diff changes are no longer required — this is now pure Juggler/TypeScript wiring. |
Member
|
@dgozman ping |
dgozman
reviewed
May 5, 2026
Collaborator
dgozman
left a comment
dgozman
left a comment
There was a problem hiding this comment.
Thank you for the PR! I think the issue is real, but the fix seems to be a very speculative one. Let us think about a better solution.
|
|
||
| const bc = this._linkedBrowser.browsingContext; | ||
| if (screenSize) { | ||
| bc.inRDMPane = false; |
Collaborator
There was a problem hiding this comment.
I don't think we can drop inRDMPane today. It triggers many things, some of which are probably still useful.
| bc.inRDMPane = false; | ||
| bc.setScreenAreaOverride(screenSize.width, screenSize.height); | ||
| } else { | ||
| bc.inRDMPane = true; |
Collaborator
There was a problem hiding this comment.
I also don't understand why we can sometimes leave without inRDMPane and in other cases we still need it. This does not seem right.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports SetScreenAreaOverride from upstream
(https://phabricator.services.mozilla.com/D273425,
mozilla-firefox/firefox@a689946)
to decouple screen dimensions from Responsive Design Mode emulation.
When screen differs from viewport, Juggler now uses
setScreenAreaOverride instead of inRDMPane — achieving parity with
how Chromium handles this via setDeviceMetricsOverride and WebKit
via setScreenSizeOverride.
Fixes #39841